<html>
<head><meta charset="utf-8"><title>triage 2021 07 27 · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2027.html">triage 2021 07 27</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="247324341"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2027/near/247324341" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2027.html#247324341">(Jul 27 2021 at 12:10)</a>:</h4>
<p>Going to be kicking this off soon!</p>



<a name="247326606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2027/near/247326606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2027.html#247326606">(Jul 27 2021 at 12:33)</a>:</h4>
<p>Done: <a href="https://github.com/rust-lang/rustc-perf/pull/941">https://github.com/rust-lang/rustc-perf/pull/941</a> (this week was very quiet)</p>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> <span class="user-mention" data-user-id="116122">@simulacrum</span> a few things we should discuss:</p>
<ul>
<li>We still have a few "untriaged" perf regressions. I'm not sure how we want to handle this. Should we continue to nag the author and/or reviewer? Should we just leave them? </li>
<li>It would be nice for perf runs that get run after merging to post their results to the PR. This way we can easily see if a perf-result improves or degrades after merging. This is particularly helpful if a perf run is performed during review and then the reviewer decides to merge despite a regression of some sort. Sometimes the commits after the initial perf run fix the perf issue, and sometimes it makes it even worse.</li>
</ul>



<a name="247327101"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2027/near/247327101" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2027.html#247327101">(Jul 27 2021 at 12:39)</a>:</h4>
<p>I think we could definitely post a comment after merge on PRs, once the run completes. I'd guess that you get the same sort of summary from the triage perf report though so you can compare with that?</p>



<a name="247328159"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2027/near/247328159" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2027.html#247328159">(Jul 27 2021 at 12:49)</a>:</h4>
<p>Yea no information is lost the way we currently do things, it just would be helpful for record keeping. Right now, we rely on the triage process to do this, but why not do it automatically?</p>



<a name="247328278"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2027/near/247328278" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2027.html#247328278">(Jul 27 2021 at 12:50)</a>:</h4>
<p>Our understanding of noise has gotten better. We should be able to avoid cases where it’s clearly noise.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>